Respect skipRegistry value from configuration files #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the skipRegistry value in configuration files is ignored, the final value is either the one the user passed on the command line, which is the intended behavior, or the value `none` if the user didn't pass a --skip-registry argument. This commit fixes this by introducing the new value `default_` to the SkippackageSuppliers enum to know when the user didn't pass the skip-registry argument and the value should be taken from the configuration files. Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5364248 bin/dub
rough build time=64sFull build output |
thewilsonator
approved these changes
Apr 27, 2024
Geod24
reviewed
Apr 28, 2024
| @@ -17,6 +17,7 @@ public enum SkipPackageSuppliers { | |||
| standard, /// Does not use the default package suppliers (`defaultPackageSuppliers`). | |||
| configured, /// Does not use default suppliers or suppliers configured in DUB's configuration file | |||
| all, /// Uses only manually specified package suppliers. | |||
| default_, /// The value wasn't specified. It is provided in order to know when it is safe to ignore it | |||
There was a problem hiding this comment.
Instead of modifying the enum, passing a Nullable would be a better option, wouldn't it ?
There was a problem hiding this comment.
When I wrote this I considered both passing a Nullable in the constructor or modifying the enum as possible solutions. My final conclusion was that I would rather not change the constructor semantics and, instead, modify the enum.
I wouldn't mind doing as you say and changing the approach to use a Nullable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the skipRegistry value in configuration files is ignored, the final value is either the one the user passed on the command line, which is the intended behavior, or the value
noneif the user didn't pass a --skip-registry argument.This commit fixes this by introducing the new value
default_to the SkippackageSuppliers enum to know when the user didn't pass the skip-registry argument and the value should be taken from the configuration files.Be aware that the output of an invalid
skipRegistryvalue indub.settings.jsonhas changed:Before this PR:
After this PR: