Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up Package.getPackageConfigs #2902

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Speed up Package.getPackageConfigs #2902

merged 2 commits into from
Apr 20, 2024

Commits on Apr 19, 2024

  1. Return early from determineDependencyConfigs if possible 

    The only package that can have a config already created is the root
package, and only if the `config` parameter isn't an empty string.
Every other package is in the `configs` array iff it was added by
a previous call to this function. The exact same configurations
will be found if this function is called again for the same (p, c)
pair and it will do needless work that won't modify anything.
    @atilaneves
    atilaneves committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f6bc0ef View commit details
    Browse the repository at this point in the history

  2. Prune the result of Package.getAllDependenciesRange

    @atilaneves
    atilaneves committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    efcda29 View commit details
    Browse the repository at this point in the history