-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge stable #2833
Merged
Merged
merge stable #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ibuclaw
commented
Jan 28, 2024
- Fix Package in local-packages not picked up after moving package into new directory structure #2691: Use same structure for managed and unmanaged path
- update version to v1.36.0-rc.1
Currently, we issue a warning asking people to migrate, but the migrated path is not actually recognized. It was suggested in the issue to ignore this warning for add-path. However, as add-path is a rather low-level use, I think it is better to impose the same condition for managed and unmanaged path, in order to be able to provide the same guarantees. For example, once we move to reading version from the path, we can provide the same speedups for add-path users. We can also make sure that add-path users don't have surprises when dealing with packages that expect a certain structure outside their directory, such as arsd and ae. Some tests were updated with the new path, however, as many will likely be rewritten with the new test framework, and a lot of tests are affected, not all of them were updated, providing coverage for the old and new code alike.
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5343584 bin/dub
rough build time=63s Full build output
|
Geod24
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.