Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logging from dub.dependency #2743

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Remove logging from dub.dependency #2743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions source/dub/dependency.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import dub.internal.vibecompat.data.json;
import dub.internal.vibecompat.inet.path;
import dub.package_;
import dub.semver;
import dub.internal.logging;

import dub.internal.dyaml.stdsumtype;

Expand Down Expand Up @@ -327,9 +326,6 @@ struct Dependency {
Dependency dep;
if( verspec.type == Json.Type.object ){
if( auto pp = "path" in verspec ) {
if (auto pv = "version" in verspec)
logDiagnostic("Ignoring version specification (%s) for path based dependency %s", pv.get!string, pp.get!string);
WebFreak001 marked this conversation as resolved.
Show resolved Hide resolved

dep = Dependency(NativePath(verspec["path"].get!string));
} else if (auto repository = "repository" in verspec) {
enforce("version" in verspec, "No version field specified!");
Expand Down Expand Up @@ -643,8 +639,6 @@ unittest {
assert(Dependency("1.0.0+foo").matches(Version("1.0.0+foo"), VersionMatchMode.strict));
assert(Dependency("~>1.0.0+foo").matches(Version("1.0.0+foo"), VersionMatchMode.strict));
assert(Dependency("~>1.0.0").matches(Version("1.0.0+foo"), VersionMatchMode.strict));

logDebug("Dependency unittest success.");
}

unittest {
Expand Down
Loading