Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wastefully execute everything via a shell #2674

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Don't wastefully execute everything via a shell #2674

merged 2 commits into from
Jul 22, 2023

Commits on Jul 20, 2023

  1. Don't wastefully execute everything via a shell 

    We should only ever use the shell if we want to use the shell's
features, such as pipes, non-trivial redirection, or shell language
features (branches/loops/etc.).  Otherwise, executing a program via
the shell is pointless and wasteful.
    @CyberShadow
    CyberShadow committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    0eeed18 View commit details
    Browse the repository at this point in the history

  2. test/issue895-local-configuration.sh: Update test 

    Failure mode is different as we're no longer asking the shell to run
the dummy program, we're doing it ourselves.
    @CyberShadow
    CyberShadow committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    609c248 View commit details
    Browse the repository at this point in the history