Skip to content

fixup #1428 #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2019
Merged

fixup #1428 #1684

merged 1 commit into from
Apr 28, 2019

Conversation

MartinNowak
Copy link
Member

  • fix Regression: Range violation #1681 - range violation with empty arg
  • add output if package wasn't found online
  • add non-interactive mode that doesn't search for online packages

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @MartinNowak!

@MartinNowak MartinNowak mentioned this pull request Apr 28, 2019
Closed
@MartinNowak
Copy link
Member Author

Sorry for craming multiple things into this PR.

@jacob-carlborg
Copy link
Contributor

The fix for #1681 looks good to me.

@MartinNowak MartinNowak requested a review from wilzbach April 28, 2019 12:37
@MartinNowak
Copy link
Member Author

MartinNowak commented Apr 28, 2019 •
edited
Loading

Let me merge the non-controversial stuff before the last commit so I can build a release candidate.
See b32f87c

@MartinNowak
add non-interactive mode to build command
491a938 
- useful to build already fetched package
- skips online search and interactive fetch dialog
wilzbach
wilzbach approved these changes Apr 28, 2019
View reviewed changes
Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wilzbach wilzbach merged commit 7ba913e into dlang:stable Apr 28, 2019
@wilzbach
Copy link
Member

I don't think it's super controversial. Thanks a lot for this!

@MartinNowak MartinNowak deleted the fixup_1428 branch August 30, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilzbach wilzbach wilzbach approved these changes

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinNowak @dlang-bot @jacob-carlborg @wilzbach @thewilsonator