Skip to content

Fix interactive remove test on systems with dub installed #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wilzbach
Copy link
Member

On my system and the Project-Tester the interactive remove test fails with 1.3.0:

Fetching dub 0.9.20...
Fetching dub 0.9.21...
Cannot remove package 'dub', there are multiple possibilities at location
'user'.
Available versions:
  1.3.0
  0.9.20
  0.9.21
Please specify a individual version using --version=... or use the wildcard --version=* to remove all versions.
Select version of 'dub' to remove from location 'user':1) 1.3.02) 0.9.203) 0.9.214) all versions> Removing dub in /home/seb/.dub/packages/dub-1.3.0/dub/Removed package: 'dub'Removed dub, version 1.3.0.
Failed to remove dub-0.9.20

Or on the Project Tester.

AFAICT for the changes to be propagated to the Project-Tester, a new tag will be required.

@wilzbach
Copy link
Member Author

@wilzbach wilzbach force-pushed the fix-interactive-remove branch from 596cec5 to 4535504 Compare June 22, 2017 03:22
@CyberShadow
Copy link
Member

@MartinNowak @s-ludwig This is affecting all of @dlang development - as things are set up currently, whenever a test fails in Dub (or another project on the project tester), no DMD/Phobos/Druntime pull requests can be merged. Would it be possible to prioritize test suite fixes which affect the project tester?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 61.646% when pulling 4535504 on wilzbach:fix-interactive-remove into 13581f8 on dlang:master.

@MartinNowak
Copy link
Member

MartinNowak commented Jun 25, 2017

Think you're misinterpreting the test output, the first check is supposed to fail and the output you've cited comes from that (would make sense to 2>/dev/null that).
https://github.com/dlang/dub/pull/1157/files#diff-0d9bd8dbd24cf9eee031c3d7269f23ddR10
What's actually failing is something further down, most likely fetching 0.9.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants