compile .c files with ImportC #3855
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3855" |
WalterBright
force-pushed
the
useImportC32
branch
from
67a61d7 to
ba487f6
Compare
WalterBright
force-pushed
the
useImportC32
branch
from
ba487f6 to
a912ef8
Compare
| UDFLAGS=-m32omf -conf= -O -release -preview=dip1000 -preview=fieldwise -w -Isrc -Iimport | ||
| DDOCFLAGS=-conf= -c -w -o- -Isrc -Iimport -version=CoreDdoc |
There was a problem hiding this comment.
Isn't this a symptom of documentation only being built on Linux/POSIX? Shouldn't the make files instead be synced up so doc generation recipes are (re?)added to the windows makefiles?
There was a problem hiding this comment.
If it's ever needed, it should be added then. Currently, it is unused and just a distraction.
There was a problem hiding this comment.
IMO, the Makefiles should all be merged to a single one for all platforms in the long-term, using GNU make. LDC uses GNU make on Windows for the druntime tests (test subdir; not using the win64.mak files for those - Windows extras have been added to the 'Posix' makefiles and can be upstreamed), so it's definitely an option.
There was a problem hiding this comment.
That would be ok with me, as long as the make program is distributed with the compiler binaries.
Use ImportC to compile .c files for druntime Win32 library