This repository was archived by the owner on Oct 12, 2022. It is now read-only.
merge stable #3793
Merged
merge stable #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MartinNowak
commented
Apr 1, 2022
MartinNowak
commented
- Add core.sys.openbsd.pwd module. Fix Issue 22908 - OpenBSD: Add getpwnam_shadow and getpwuid_shadow function prototypes
- Fix 20778 - Ensure that _d_print_throwable prints the entire message
- test/exceptions: Only print expected output if test fails
- Fix 21086 - Correct link core.thread.context
Fix Issue 22908 - OpenBSD: Add getpwnam_shadow and getpwuid_shadow function prototypes
The previous implementation simply forwarded the pointer + length to `fprintf` and didn't check the return value. This caused the message to be truncated for the following cases: - it contains `\0` (the bug report) - the length is greater than `int.max` This commit changes the implementation s.t. it uses `fwrite` instead which doesn't stop at `\0` and (theoretically) supports lengths up to `size_t.max`
To reduce the noise and save some time
…ion-message Fix 20778 - Ensure that _d_print_throwable prints the entire message
The file is named `context.d`, not `package.d`.
|
Thanks for your pull request, @MartinNowak! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3793" |
dlang-bot
added
Bug Fix
dkorpel
approved these changes
Apr 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.