Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Fix return scope -> return ref in as_array() #3783

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Mar 22, 2022

return scope was added to core.stdcpp.string.basic_string.as_array in #3754 for version(CppRuntime_Microsoft) and in #3757 for version(CppRuntime_Clang), because theinout -> return ref implication was removed and return/scope inference was not good at dealing with the ambiguity of return ref and return scope.

Now with dlang/dmd#13860, it turns out that for version(CppRuntime_Clang) return scope is incorrect, because it has a small buffer optimization, so it should be return ref. For uniformity, I made the version(CppRuntime_Microsoft) return ref as well.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3783"

@dkorpel dkorpel merged commit 69ca60d into dlang:master Mar 22, 2022
@dkorpel dkorpel deleted the cppstring-as-array-scope branch March 22, 2022 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants