Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Apr 14, 2019

Part of LDC since v1.10 (and has been rotting here upstream as part of #2151 for almost a year now).

Adding support for DWARF v4 and 64-bit DWARF as well as fixing alignment
issues for non-x86 architectures.
@kinke kinke requested review from andralex and wilzbach as code owners April 14, 2019 23:29
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2559"

@thewilsonator
Copy link
Contributor

thewilsonator commented Apr 15, 2019

cc @CyberShadow whats with the ae failure? Looks unrelated, please doublecheck and merge if all good. Ah, I see it fails elsewhere too.

@thewilsonator thewilsonator merged commit 45cb1f1 into dlang:master Apr 15, 2019
@CyberShadow
Copy link
Member

@thewilsonator Yes, see dlang/dmd#9618 (comment)

@kinke kinke deleted the bt_dwarf2 branch April 15, 2019 21:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants