Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@WalterBright
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2394"

@CyberShadow
Copy link
Member

These are pretty terrible.

It's even worse thinking that D users will need to do the same for similar code in their local bindings.

@n8sh
Copy link
Member

n8sh commented Jan 7, 2019

Does this cause problems for LDC2 or can this just be merged?

@n8sh n8sh added the 72h no objection -> merge The PR will be merged if there are no objections raised. label Jan 7, 2019
@ibuclaw ibuclaw removed the 72h no objection -> merge The PR will be merged if there are no objections raised. label Jan 7, 2019
@ibuclaw
Copy link
Member

ibuclaw commented Jan 7, 2019

Static if would be better, making sure that wchar_t is a distinct type, and not an alias.

@rainers
Copy link
Member

rainers commented Jan 7, 2019

FWIW: I agree with most that these changes are pretty bad, the cure seems worse than the disease (AFAICT mangling of C++ functions that happen to use wchar_t, too). I think we should further explore a way to define aliases that only affect C++ mangling of the symbol, but not the function type, as if pragma(mangle) is being used.

@jacob-carlborg
Copy link
Contributor

I think we should further explore a way to define aliases that only affect C++ mangling of the symbol, but not the function type, as if pragma(mangle) is being used.

dlang/dmd#7458

My conclusion of that PR:

The issue is, as Rainer pointed out, that the mangling is used for type comparison as well. An alias with pragma(mangle) is not intended to introduce a new type.

@rainers
Copy link
Member

rainers commented Jan 7, 2019

dlang/dmd#7458

Maybe your PR can work if it is only applied to C++ symbol mangling. Type comparison happens for D mangling. It should probably use another pragma then.

@jacob-carlborg
Copy link
Contributor

Maybe your PR can work if it is only applied to C++ symbol mangling. Type comparison happens for D mangling. It should probably use another pragma then.

Possibly.

@dlang-bot dlang-bot added Needs Rebase needs a `git rebase` performed stalled labels May 27, 2021
@RazvanN7
Copy link
Contributor

RazvanN7 commented Nov 5, 2021

Closing as per @rainers comment and lack of activity.

@RazvanN7 RazvanN7 closed this Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Needs Rebase needs a `git rebase` performed stalled

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants