Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

set core.stdc.stdint types so mangling matches C++ #2183

Merged
merged 1 commit into from
May 18, 2018
Merged

set core.stdc.stdint types so mangling matches C++ #2183

merged 1 commit into from
May 18, 2018

Conversation

@WalterBright
Copy link
Member

@WalterBright WalterBright commented May 16, 2018 •
edited
Loading

Provides better interoperability with C++, hence betterC.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2183"

@WalterBright WalterBright mentioned this pull request May 16, 2018
Merged
@WalterBright
Copy link
Member Author

Blocking dlang/dmd#8252

@WalterBright WalterBright added the Vision Vision Plan https://wiki.dlang.org/Vision/2018H1 label May 16, 2018
@WalterBright WalterBright mentioned this pull request May 16, 2018
Merged
JinShil
JinShil reviewed May 18, 2018
View reviewed changes
src/core/stdc/config.d
enum isPosix = false;
static if (isPosix && (void*).sizeof > int.sizeof)
{
alias ddoc_long = long;
Copy link
Contributor

@JinShil JinShil May 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we need these itermediate ddoc_ aliases here. Can't we just declare c_long and c_ulong here?

@JinShil
Copy link
Contributor

JinShil commented May 18, 2018

There's an awful lot of redundancy in this patch and it makes review a little difficult. Can't we just version out the differences?

JinShil
JinShil approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@JinShil JinShil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, nothing I've said above should prevent this from being merged.

@WalterBright
Copy link
Member Author

There's an awful lot of redundancy in this patch and it makes review a little difficult. Can't we just version out the differences?

I tried that initially. The result was incomprehensible.

@JinShil
Copy link
Contributor

JinShil commented May 18, 2018

@WalterBright Please note that although I approved this, I'm not on Team DRuntime. I'll send you an e-mail about this.

@WalterBright
Copy link
Member Author

I put you on the team. Druntime can use your help.

@dlang-bot dlang-bot merged commit 111bfc4 into dlang:master May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ibuclaw ibuclaw Awaiting requested review from ibuclaw

@schveiguy schveiguy Awaiting requested review from schveiguy

1 more reviewer

@JinShil JinShil JinShil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Blocking Other Work Vision Vision Plan https://wiki.dlang.org/Vision/2018H1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WalterBright @dlang-bot @JinShil