Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Apr 2, 2018

Follow-up to #7714

For some reason SemaphoreCI didn't want to run on this PR and it turns out that gdmd doesn't support -lib.

See e.g. https://semaphoreci.com/dlang/dmd-2/branches/master/builds/391

@wilzbach wilzbach requested a review from MartinNowak as a code owner April 2, 2018 05:51
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8111"

@wilzbach
Copy link
Contributor Author

wilzbach commented Apr 2, 2018

FreeBSD failure looks unrelated -> https://issues.dlang.org/show_bug.cgi?id=18704

edit: yep, it was:

image

@ibuclaw
Copy link
Member

ibuclaw commented Apr 2, 2018

it turns out that gdmd doesn't support -lib.

It does support -lib, so maybe you could be a bit more specific or have a look at the -vdmd output of the script and fix whatever is wrong. ;-)

@wilzbach
Copy link
Contributor Author

wilzbach commented Apr 2, 2018

This is the failing line for gdmd:

/home/seb/dlang/gdc-4.8.5/bin/gdmd -lib -of../generated/linux/release/64/backend.a abc.o

or have a look at the -vdmd output of the script and fix whatever is wrong

Sure - D-Programming-GDC/gdmd#5

Though we should still merge this PR here as the gdc release we use here (aka the "latest") is from 2016.

@ibuclaw
Copy link
Member

ibuclaw commented Apr 2, 2018

The gdmd wrapper is only superficial, and currently the ci pulls the latest copy anyway.

@wilzbach
Copy link
Contributor Author

wilzbach commented Apr 2, 2018

The gdmd wrapper is only superficial, and currently the ci pulls the latest copy anyway.

It's locked to a specific commit:

https://github.com/dlang/installer/blob/2e3086a02305637d119e252e539e47f365228ec0/script/install.sh#L554

So an update is needed -> dlang/installer#316

While I could merge it at the installer, I don't have the permissions to deploy the installer script.
So I think we should still go with $(AR) for now ;-)

@wilzbach wilzbach merged commit 0d1328f into dlang:master Apr 2, 2018
@wilzbach wilzbach deleted the gdc-semaphore branch April 2, 2018 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants