Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify path delimiters in win32.mak #6602

Closed
wants to merge 1 commit into from

Conversation

e10s
Copy link
Contributor

@e10s e10s commented Mar 8, 2017

Currently '/' and '\' are mixedly used but this PR replaces the former with the latter to avoid possible confusion.

@WalterBright
Copy link
Member

It's been like this for 17 years now, and there are no reports of confusion. The trouble with mass changes like this is they make things harder to track with git blame. I need a better reason to approve this.

@e10s
Copy link
Contributor Author

e10s commented Mar 8, 2017

Okay, I've been hacking broken win64 build system and found this inconsistency. E.g., $G/strtold.obj on win32 against win64's $D\strtold.obj and $G\longdouble.obj against $D\longdouble.obj. In addition, the MAKE program distinguishes '/' and '\'. Because these confused me, I thought they should be unified for coming hacks.

Overkill? Should be a just follow-up of the recent PR #6562?

@RazvanN7
Copy link
Contributor

RazvanN7 commented Mar 8, 2017

I agree with this PR not because the inconsistent use of \ and / is confusing, but rather annoying.
CC @WalterBright

@ibuclaw
Copy link
Member

ibuclaw commented Jan 10, 2018

I agree with Walter here too, sorry. Closing as this has stalled.

@ibuclaw ibuclaw closed this Jan 10, 2018
@e10s e10s deleted the win32mak_unify_delimiter branch February 20, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants