add eSink to initializerSemantic() - #23582
Open
WalterBright wants to merge 1 commit into
Open
Conversation
WalterBright
added
Review:Easy Review
Severity:Refactoring
DMD perf check
|
WalterBright
force-pushed
the
initializerSemantic
branch
from
August 12, 2026 22:35
45d23ea to
cb85b2a
Compare
WalterBright
force-pushed
the
initializerSemantic
branch
from
August 12, 2026 22:37
cb85b2a to
5f9109a
Compare
| import dmd.expression /*: Expression*/; | ||
| import dmd.func : FuncDeclaration; | ||
| import dmd.globals : dinteger_t, uinteger_t, JsonFieldFlags, CppStdRevision; | ||
| import dmd.globals : dinteger_t, uinteger_t, JsonFieldFlags, CppStdRevision, global; |
Contributor
There was a problem hiding this comment.
please put this as a local import...
| { | ||
| import dmd.initsem; | ||
| return dmd.initsem.initializerSemantic(init, sc, tx, needInterpret); | ||
| return dmd.initsem.initializerSemantic(init, sc, tx, needInterpret, global.errorSink); |
Contributor
There was a problem hiding this comment.
... here so that the imports of dmd.global are as small as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.