Skip to content

[DO NOT MERGE] Implement PoC DFA engine for nullability and truthiness #21494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rikkimax
Copy link
Contributor

Throwing the experimental fast DFA engine at CI to see what happens, this PR is not going to be merged can be ignored.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21494"

@rikkimax rikkimax force-pushed the idea-dfa branch 7 times, most recently from c1f7ebf to f85972d Compare June 29, 2025 16:03
@rikkimax
Copy link
Contributor Author

rikkimax commented Jun 29, 2025

Ugh isBinExp doesn't work for EXP.loweredAssignExp flags are not set for it even though the hierarchy matches.

@rikkimax rikkimax force-pushed the idea-dfa branch 21 times, most recently from a4354e5 to b741ece Compare July 1, 2025 03:48
@rikkimax rikkimax force-pushed the idea-dfa branch 15 times, most recently from bd153c4 to 209b008 Compare July 15, 2025 17:12
@rikkimax rikkimax force-pushed the idea-dfa branch 13 times, most recently from a1c95df to d4555f1 Compare July 20, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants