Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract expression.resolveLoc and move it to expressionsem #15782

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Nov 7, 2023

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15782"

@thewilsonator
Copy link
Contributor

Merge conflicts

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Nov 7, 2023

Fixed.

@RazvanN7 RazvanN7 merged commit f199a2d into dlang:master Nov 7, 2023
43 checks passed
@RazvanN7 RazvanN7 changed the title Extract expression.resolveLoc and move it expressionsem Extract expression.resolveLoc and move it to expressionsem Jan 25, 2024
veelo added a commit to veelo/dmd that referenced this pull request Mar 3, 2024
These require `import dscope` that we want to remove from func.d in pursuit of https://github.com/orgs/dlang/projects/41.

Other functions that still need to be moved include `overloadApply()`, `isUnique()` and `equals()`, the latter needing a visitor akin dlang#15782.
veelo added a commit to veelo/dmd that referenced this pull request Mar 3, 2024
These require `import dscope` that we want to remove from func.d in pursuit of https://github.com/orgs/dlang/projects/41.

Other functions that still need to be moved include `overloadApply()`, `isUnique()` and `equals()`, the latter needing a visitor akin dlang#15782.
veelo added a commit to veelo/dmd that referenced this pull request Mar 3, 2024
These require `import dscope` that we want to remove from func.d in pursuit of https://github.com/orgs/dlang/projects/41.

Other functions that still need to be moved include `overloadApply()`, `isUnique()` and `equals()`, the latter needing a visitor akin dlang#15782.
thewilsonator pushed a commit that referenced this pull request Mar 3, 2024
These require `import dscope` that we want to remove from func.d in pursuit of https://github.com/orgs/dlang/projects/41.

Other functions that still need to be moved include `overloadApply()`, `isUnique()` and `equals()`, the latter needing a visitor akin #15782.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants