Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated makefile to use dmd/generated/os/release/model/dmd #1598

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Mar 3, 2017

I saw there is also the variable $(DMD_STABLE_DIR) which is used for $(DMD-REL) that uses the hierarchy dmd/src/dmd. I didn't modify that one to point to generated/.../dmd since I assume that the changes in [1] are not stable yet.

[1] dlang/dmd#6562

Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilzbach
Copy link
Member

wilzbach commented Mar 3, 2017

Two additional things I found while scanning posix.mak that could be done as part of this PR or later.

  1. I think you should add dmd to the list of dumped modules for the prerelease docs
    (this isn't a blocker, you can also do it after your ddmd -> dmd move)

-> https://github.com/dlang/dlang.org/blob/master/posix.mak#L277

$(addprefix --dump , object std etc core ddmd) >$@
  1. Would you be so kind to remove the redundant DMD_GEN variable and replace its occurrences with DMD?
L96:
DMD_GEN=$(DMD_DIR)/generated/$(OS)/release/$(MODEL)

@wilzbach
Copy link
Member

wilzbach commented Mar 3, 2017

MartinNowak added the auto-merge label 4 minutes ago

@MartinNowak the dlang-bot doesn't receive hooks from dlang.org.
See also: #1595 (comment)

@dlang-bot dlang-bot merged commit 696bf2b into dlang:master Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants