Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ldc to the supported compilers #85

Merged
merged 3 commits into from
Oct 17, 2020
Merged

Add ldc to the supported compilers #85

merged 3 commits into from
Oct 17, 2020

Conversation

ljmf00
Copy link
Contributor

@ljmf00 ljmf00 commented Oct 3, 2020 •
edited
Loading

This PR will add support for LDC compiler. I'm not quite sure if it's better to refactor DMD Engine to be widely supported for every D compiler. Currently ldmd supports arguments of dmd using ldc.

Fixes #75 .

@ljmf00 ljmf00 changed the title ci: add ldc to the supported compilers WIP: ci: add ldc to the supported compilers Oct 3, 2020
@ljmf00 ljmf00 marked this pull request as draft October 3, 2020 23:20
@ljmf00 ljmf00 changed the title WIP: ci: add ldc to the supported compilers WIP: Add ldc to the supported compilers Oct 3, 2020
@ljmf00 ljmf00 force-pushed the add-compilers-ci branch 6 times, most recently from 0ac5711 to a417ee9 Compare October 4, 2020 20:07
@ljmf00 ljmf00 changed the title WIP: Add ldc to the supported compilers Add ldc to the supported compilers Oct 4, 2020
@ljmf00 ljmf00 marked this pull request as ready for review October 4, 2020 20:10
@ljmf00
Copy link
Contributor Author

ljmf00 commented Oct 4, 2020

@MartinNowak can you take a look at this? I'm not sure if the library name is the same across all systems, but I supposed.

MartinNowak
MartinNowak approved these changes Oct 4, 2020
View reviewed changes
Copy link
Collaborator

@MartinNowak MartinNowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right, think the dmd interfaces are fine.

@ljmf00
Copy link
Contributor Author

ljmf00 commented Oct 4, 2020

Looks about right, think the dmd interfaces are fine.

Would be cool to add more tests with at least one more linux distro to differ the environment. I'm saying that because I had issues with compiler passed to DMD environment variable. In archlinux ldmd is actually symbolic linked to ldmd2.

ljmf00 added 3 commits October 4, 2020 21:27
@ljmf00
ci: add ldc to the supported compilers
b95580f 
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
@ljmf00
engines: dmd: add support for ldc
0270f4d 
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
@ljmf00
dub: add ldc libs linkage and generalize libdl linkage
c5356a2 
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
@ljmf00
Copy link
Contributor Author

ljmf00 commented Oct 4, 2020

Rebased with master

@ljmf00
Copy link
Contributor Author

ljmf00 commented Oct 17, 2020

Looks about right, think the dmd interfaces are fine.

@MartinNowak did you forgot to merge? I already rebased with master.

@MartinNowak MartinNowak merged commit 10bfa9b into dlang-community:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinNowak MartinNowak MartinNowak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support LDC?
2 participants
@ljmf00 @MartinNowak