Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a unittest inside
Interpreter
template can cause compiler error when I built drepl with unittest or used as a library. The problem is comparison betweenInterpreter!EchoEngine.Kind
andInterpreter!(<Instantiated Type>).Kind
in the unittest.For example, when I instantiated
Interpreter!DMDEngine
inside unittest caused following compiler error.Therefore, I propose adding
static if
to limit the unittest instantiation only withEchoEngine
.