Fix CI failure starting from DMD 2.085 #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
stdx-allocs+Meson
branch
from
a63062b to
87a48d7
Compare
ghost
changed the title
ghost
changed the title
ghost
commented
Mar 12, 2019
| @@ -565,7 +565,7 @@ private: | |||
| static if (BookkeepingType.sizeof < uint.sizeof) | |||
| immutable uint notReg = ~(cast(uint) registry); | |||
| else | |||
| immutable uint notReg = ~registry; | |||
| immutable uint notReg = cast(uint) (~registry); | |||
There was a problem hiding this comment.
@Hackerpilot , to answer to a previous review comment (#137), the two branches are not the same. The first is to fix the deprecation message related to integral promotion not done, the other fixes the issue.
ghost
commented
Mar 13, 2019
| @@ -27,3 +27,4 @@ script: | |||
| - ninja -j8 -C build test -v | |||
| - git submodule update --init --recursive | |||
| - make -B -C test/ | |||
| - dub test | |||
|
Any objection ? I'll wait till Monday because we cant stay stuck to the fixed container version (because of #136) for ever. It's time to move forward. |
wilzbach
approved these changes
Mar 16, 2019
|
Thanks! |
|
Thanks this should allow dlangide to be built without error |
|
Sorry for the lack of responses. I was on vacation last week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.