added some features to sortable_columns#1
Open
aldavidson wants to merge 8 commits intodlabare:masterfrom
Open
Conversation
…rt by columns plus named methods
…allow sorting by methods (not just columns)
… call - this enables a view template to interrogate those params and e.g. display appropriate icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for sortable_columns, it's really handy. If you're interested, I've added a couple of features in my fork:
This is really useful when you're sorting a collection of models by some attribute on an associated record (e.g. to sort @payments by payment.account.name, you'd define :
class Payment < ActiveRecord::Base
belongs_to :account
sortable_methods [:account_name, :some_other_method]
def account_name
self.account.name
end
end
( I added the sortable_methods requirement to avoid a security hole - e.g. sort_by=destroy)
when you're on a url with non-sort parameters (e.g. /things/index?parent_id=1234 ) it now maintains existing params when you click on a sortable column header
As a result of the other two changes, I centralized the logic for validating sort params into one place rather than two
Cheers,
Al