Skip to content

Private vars & getters #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2023
Merged

Private vars & getters #44

merged 4 commits into from
May 25, 2023

Conversation

dovgopoly
Copy link
Member

@dovgopoly dovgopoly commented May 24, 2023

  • Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

@dovgopoly dovgopoly marked this pull request as ready for review May 24, 2023 13:10
@dovgopoly dovgopoly requested a review from Arvolear May 24, 2023 13:10
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (10a114c) 100.00% compared to head (8c91f7a) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          872       882   +10     
  Branches       124       124           
=========================================
+ Hits           872       882   +10     
Impacted Files Coverage Δ
...ompound-rate-keeper/AbstractCompoundRateKeeper.sol 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@Arvolear Arvolear merged commit d4ede82 into master May 25, 2023
@Arvolear Arvolear deleted the fix/getters branch May 25, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants