[Multiwindow] Backing store and compositor

.ci.yaml

@@ -56,7 +56,7 @@ platform_properties:
       device_type: none
       cpu: x86
       os: Mac-12
-      xcode: 13a233 # xcode 13.0
+      xcode: 14a5294e # xcode 14.0 beta 5
   windows:
     properties:
       build_host: "false"
@@ -194,6 +194,17 @@ targets:
       lint_android: "false"
       lint_host: "true"
     timeout: 60
+    runIf:
+      - DEPS
+      - .ci.yaml
+      - tools/**
+      - ci/**
+      - "**.h"
+      - "**.c"
+      - "**.cc"
+      - "**.fbs"
+      - "**.frag"
+      - "**.vert"
 
   - name: Linux Android clang-tidy
     recipe: engine/engine_lint
@@ -203,6 +214,18 @@ targets:
       lint_android: "true"
       lint_host: "false"
     timeout: 60
+    runIf:
+      - DEPS
+      - .ci.yaml
+      - tools/**
+      - ci/**
+      - "**.h"
+      - "**.c"
+      - "**.cc"
+      - "**.fbs"
+      - "**.frag"
+      - "**.vert"
+      - "**.py" # Run pylint on the fastest clang-tidy builder.
 
   - name: Linux Arm Host Engine
     recipe: engine/engine_arm
@@ -213,34 +236,31 @@ targets:
 
   - name: Linux linux_arm_host_engine
     recipe: engine_v2/engine_v2
-    bringup: true
     timeout: 60
     properties:
+      release_build: "true"
       config_name: linux_arm_host_engine
-      environment: Staging
 
   - name: Linux linux_host_engine
     recipe: engine_v2/engine_v2
     timeout: 60
     properties:
+      release_build: "true"
       config_name: linux_host_engine
-      environment: Production
 
   - name: Linux linux_android_aot_engine
     recipe: engine_v2/engine_v2
-    bringup: true
     timeout: 60
     properties:
+      release_build: "true"
       config_name: linux_android_aot_engine
-      environment: Staging
 
   - name: Linux linux_android_debug_engine
     recipe: engine_v2/engine_v2
-    bringup: true
     timeout: 60
     properties:
+      release_build: "true"
       config_name: linux_android_debug_engine
-      environment: Staging
 
   - name: Linux Web Engine
     recipe: engine/web_engine
@@ -306,18 +326,15 @@ targets:
 
   - name: Mac mac_android_aot_engine
     recipe: engine_v2/engine_v2
-    bringup: true
     timeout: 60
     properties:
       config_name: mac_android_aot_engine
-      environment: Staging
 
   - name: Mac mac_host_engine
     recipe: engine_v2/engine_v2
     timeout: 60
     properties:
       config_name: mac_host_engine
-      environment: Production
 
   - name: Mac Unopt
     recipe: engine/engine_unopt
@@ -329,28 +346,51 @@ targets:
           "ios-13-0",
           "ios-16-0_14a5294e"
         ]
-      xcode: 14a5294e # xcode 14.0 beta 5
     timeout: 75
 
   - name: Mac Host clang-tidy
     recipe: engine/engine_lint
     properties:
       add_recipes_cq: "true"
       jazzy_version: "0.14.1"
-      xcode: 14a5294e # xcode 14.0 beta 5
       lint_host: "true"
       lint_ios: "false"
     timeout: 75
+    runIf:
+      - DEPS
+      - .ci.yaml
+      - tools/**
+      - ci/**
+      - "**.h"
+      - "**.c"
+      - "**.cc"
+      - "**.fbs"
+      - "**.frag"
+      - "**.vert"
+      - "**.m"
+      - "**.mm"
 
   - name: Mac iOS clang-tidy
     recipe: engine/engine_lint
     properties:
       add_recipes_cq: "true"
       jazzy_version: "0.14.1"
-      xcode: 14a5294e # xcode 14.0 beta 5
       lint_host: "false"
       lint_ios: "true"
     timeout: 75
+    runIf:
+      - DEPS
+      - .ci.yaml
+      - tools/**
+      - ci/**
+      - "**.h"
+      - "**.c"
+      - "**.cc"
+      - "**.fbs"
+      - "**.frag"
+      - "**.vert"
+      - "**.m"
+      - "**.mm"
 
   - name: Mac iOS Engine
     recipe: engine/engine
@@ -382,31 +422,25 @@ targets:
 
   - name: Mac mac_ios_engine
     recipe: engine_v2/engine_v2
-    bringup: true
     timeout: 60
     properties:
       config_name: mac_ios_engine
-      environment: Staging
       dependencies: >-
         [
           {"dependency": "jazzy", "version": "0.14.1"}
         ]
 
   - name:  Mac mac_ios_engine_profile
     recipe: engine_v2/engine_v2
-    bringup: true
     timeout: 60
     properties:
       config_name: mac_ios_engine_profile
-      environment: Staging
 
   - name:  Mac mac_ios_engine_release
     recipe: engine_v2/engine_v2
-    bringup: true
     timeout: 60
     properties:
       config_name: mac_ios_engine_release
-      environment: Staging
 
   - name: Windows Android AOT Engine
     recipe: engine/engine
@@ -429,15 +463,13 @@ targets:
     timeout: 60
     properties:
       config_name: windows_android_aot_engine
-      environment: Staging
 
   - name: Windows windows_host_engine
     recipe: engine_v2/engine_v2
     bringup: true
     timeout: 60
     properties:
       config_name: windows_host_engine
-      environment: Staging
 
   - name: Windows Unopt
     recipe: engine/engine_unopt
@@ -466,6 +498,7 @@ targets:
     runIf:
       - DEPS
       - .ci.yaml
+      - ci/**
 
   - name: Mac iOS Engine Release
     recipe: engine/engine
@@ -477,6 +510,7 @@ targets:
     runIf:
       - DEPS
       - .ci.yaml
+      - ci/**
 
   - name: Linux ci_yaml engine roller
     bringup: true

.clang-tidy

@@ -1,4 +1,6 @@
 # Prefix check with "-" to ignore.
+# Note: Some of the checks here are used as errors selectively, see
+# //ci/lint.sh
 Checks: "bugprone-use-after-move,\
 clang-analyzer-*,\
 clang-diagnostic-*,\
@@ -19,6 +21,8 @@ performance-unnecessary-value-param"
 # Add checks when all warnings are fixed
 # to prevent new warnings being introduced.
 # https://github.com/flutter/flutter/issues/93279
+# Note: There are platform specific warnings as errors in
+# //ci/lint.sh
 WarningsAsErrors: "bugprone-use-after-move,\
 clang-analyzer-*,\
 readability-identifier-naming,\

.github/PULL_REQUEST_TEMPLATE.md

@@ -10,8 +10,7 @@
 - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
 - [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
 - [ ] I listed at least one issue that this PR fixes in the description above.
-- [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
-writing and running engine tests.
+- [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
 - [ ] I updated/added relevant documentation (doc comments with `///`).
 - [ ] I signed the [CLA].
 - [ ] All existing and new tests are passing.

.github/workflows/scorecards-analysis.yml

@@ -15,11 +15,11 @@ jobs:
     if: ${{ github.repository == 'flutter/engine' }}
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
+        uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
         with:
           persist-credentials: false
       - name: "setup python"
-        uses: actions/setup-python@b55428b1882923874294fa556849718a1d7f2ca5
+        uses: actions/setup-python@13ae5bb136fac2878aff31522b9efb785519f984
         with:
           python-version: '3.7.7' # install the python version needed
       - name: "execute py script"
@@ -38,11 +38,11 @@ jobs:
       id-token: write
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
+        uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
         with:
           persist-credentials: false
       - name: "Run analysis"
-        uses: ossf/scorecard-action@865b4092859256271290c77adbd10a43f4779972
+        uses: ossf/scorecard-action@e363bfca00e752f91de7b7d2a77340e2e523cb18
         with:
           results_file: results.sarif
           results_format: sarif
@@ -65,6 +65,6 @@ jobs:
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: "Upload to code-scanning"
-        uses: github/codeql-action/upload-sarif@86f3159a697a097a813ad9bfa0002412d97690a4
+        uses: github/codeql-action/upload-sarif@ec3cf9c605b848da5f1e41e8452719eb1ccfb9a6
         with:
           sarif_file: results.sarif

BUILD.gn

@@ -12,6 +12,8 @@ import("//third_party/dart/build/dart/copy_tree.gni")
 
 # Whether to build the dartdevc sdk, libraries, and source files
 # required for the flutter web sdk.
+# TODO(jacksongardner): remove this poorly named argument once the recipes stop
+# using it. https://github.com/flutter/flutter/issues/113303
 declare_args() {
   full_dart_sdk = false
 }
@@ -33,7 +35,7 @@ config("export_dynamic_symbols") {
   if (is_linux || is_fuchsia) {
     inputs = [ "//flutter/common/exported_symbols.sym" ]
     ldflags = [ "-Wl,--dynamic-list=" + rebase_path(inputs[0], root_build_dir) ]
-  } else if (is_mac && !use_xcode) {
+  } else if (is_mac) {
     inputs = [ "//flutter/common/exported_symbols_mac.sym" ]
     ldflags = [
       "-Xlinker",
@@ -44,30 +46,6 @@ config("export_dynamic_symbols") {
   }
 }
 
-if (flutter_prebuilt_dart_sdk) {
-  copy_trees("_copy_trees") {
-    sources = [
-      {
-        target = "copy_dart_sdk"
-        visibility = [ ":dart_sdk" ]
-        source = prebuilt_dart_sdk
-        dest = "$root_out_dir/dart-sdk"
-        ignore_patterns = "{}"
-      },
-    ]
-  }
-}
-
-group("dart_sdk") {
-  if (build_engine_artifacts) {
-    if (flutter_prebuilt_dart_sdk) {
-      public_deps = [ ":copy_dart_sdk" ]
-    } else {
-      public_deps = [ "//third_party/dart:create_sdk" ]
-    }
-  }
-}
-
 group("flutter") {
   testonly = true
 
@@ -96,7 +74,7 @@ group("flutter") {
 
     if (build_engine_artifacts) {
       public_deps += [
-        ":dart_sdk",
+        "//flutter/build/dart:dart_sdk",
         "//flutter/flutter_frontend_server:frontend_server",
 
         # This must be listed explicitly for desktop cross-builds since
@@ -135,6 +113,7 @@ group("flutter") {
       "//flutter/display_list:display_list_benchmarks",
       "//flutter/display_list:display_list_builder_benchmarks",
       "//flutter/fml:fml_benchmarks",
+      "//flutter/impeller/geometry:geometry_benchmarks",
       "//flutter/lib/ui:ui_benchmarks",
       "//flutter/shell/common:shell_benchmarks",
       "//flutter/third_party/txt:txt_benchmarks",
@@ -272,3 +251,13 @@ if (is_fuchsia && enable_unittests) {
     deps = [ "//flutter/shell/platform/fuchsia:tests" ]
   }
 }
+
+# On Windows, when targeting Android, we only build gen_snapshot. This
+# top-level target provides a convenient shorthand for the full path into the
+# Dart tree, and is less ambiguous than specifying the binary to build since
+# we can specify the toolchain to use, too.
+if (host_os == "win") {
+  group("gen_snapshot") {
+    deps = [ "//third_party/dart/runtime/bin:gen_snapshot($host_toolchain)" ]
+  }
+}