ci: run wp-env on WordPress 7.0 - #4
Merged
Merged
Conversation
Align the local/CI test environment with the readme "Tested up to: 7.0" claim. Full suite re-verified on 7.0: unit 44, integration 15, e2e 6 — all green, and the editor renders correctly (selection panel + icon picker) in the 7.0 admin. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dknauss
added a commit
that referenced
this pull request
Aug 10, 2026
…142) DECISION: keep forcing unfold, stop lying about it, de-hardcode the width. Forced unfold is KEPT and the reasoning is recorded rather than assumed. A folded menu is a 36px icon rail with hover flyouts; Maestro's model is click-a-row and edit its label, so you cannot rename what you cannot read, and submenu editing would happen inside a flyout that vanishes when the pointer leaves. docs/archive/FIXES.md #4 records that the editing UI BROKE in folded mode historically — forcing unfold was the fix, not an oversight. The rejected alternative (adapt the editor to a 36px rail) is recorded too: much larger work whose payoff is editing in a mode where the labels being edited are invisible. What changes is the honesty. #collapse-menu currently renders, takes focus and does nothing, via a capture-phase preventDefault + stopImmediatePropagation. It becomes visibly and programmatically disabled with a reason, matching the treatment Phase 25 gave the derived-locked checkbox: a dead control that LOOKS dead is not a bug, a live-looking one is. I ALSO MIS-FRAMED THE CONFLICT ON 2026-08-09 AND HAVE WITHDRAWN IT. There is no fold-versus-width design conflict. `160px` is hardcoded in three places (maestro.css :22 width, :28 margin-left, :523 the toolbar's left edge), one of which is the exact constant the width feature makes configurable. That is a constant needing to become a variable. Outside edit mode width applies to the expanded menu and folding works normally; inside edit mode folding is off, so width simply applies. The decision UNBLOCKS the width work rather than constraining it, and both todos now say so in both directions. Phase 28 folds the two together, in dependency order: 28-01 is independently shippable and fixes today's defect: one source of truth for the width, and an honest collapse control. It deliberately changes no rendering at the default, because a refactor that also shifts layout by a pixel is two changes wearing one commit. 28-02 crosses the line this feature actually turns on — applying width while merely BROWSING wp-admin. Every asset today is edit-mode-gated except the admin-bar CSS, so "costs nothing unless you are editing" is true now and stops being, for every admin user on every page load. Task 1 is a checkpoint on delivery mechanism and, more importantly, on the OPTION READ — the cost is the non-autoloaded get_option, not the CSS. Measured numbers required, not adjectives. 28-03 adds the control. Flagged there: this is the first GLOBAL setting in a plugin built entirely from per-item overrides, so it must not read as a property of the selected row, and Reset Item versus Reset All semantics need deciding with it rather than discovering later. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps wp-env core to WordPress 7.0 to match the readme
Tested up to: 7.0claim. Full suite re-verified on 7.0: unit 44 / integration 15 / e2e 6 green; editor renders correctly in the 7.0 admin.