docs(planning): record v1.5.1 shipped, and diagnose the deploy trigger - #147
Merged
Merged
Conversation
v1.5.1 verified FROM SVN rather than the wp.org API: trunk Stable tag 1.5.1, tags/1.5.1/ present and carrying the actual 1.5.1 CODE (reserved-slot min-width, the #72aee6 ring, aria-describedby, isChildRoleLockedByParent, the norm_skip fold) rather than merely the right version string, assets/ intact. The more useful finding is the second one. STATE.md has carried "the SVN deploy is not automatic — plan the step in" as a standing lesson for FOUR consecutive releases, framed as something to remember. It is not a discipline problem. wp-deploy.yml declares `release: types: [published]`, and that path has fired zero times in six releases — every deploy in the repo's history is workflow_dispatch. Cause confirmed in source, not inferred: release.yml:36 publishes the Release with softprops/action-gh-release@v3 and no `token:` input, so it authenticates as GITHUB_TOKEN — and GitHub does not create workflow runs from GITHUB_TOKEN- generated events. The trigger cannot fire. The lesson was scar tissue over a workflow that declares automation it is structurally unable to perform. Worth fixing rather than remembering because the failure is quiet in the worst way: tag lands, Release publishes with its ZIP, CI is green, and every visible signal says shipped while users still have the previous version. Todo recommends having release.yml invoke the deploy directly over adding a PAT — the PAT defeats a loop-guard that exists for good reasons, which is a real security tradeoff for a convenience win. It also says not to delete the manual step in the same change that adds the automation, since only a real release can prove the fix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things: the v1.5.1 release record, and a CI finding that is worth more than the release itself.
v1.5.1 — verified from SVN
Tag
v1.5.1on9caa65d. Checked against SVN rather than the wp.org API's laggingversionfield:trunkStable tag reads 1.5.1tags/1.5.1/exists and carries the actual code — the reserved-slotmin-width: 24px, the#72aee6ring,aria-describedby,isChildRoleLockedByParent, thenorm_skipfold — not merely the right version string (the v1.4.0 lesson)assets/intact: 2 banners, 2 icons, 6 screenshotsThe deploy trigger is dead by construction
STATE.md has carried "the SVN deploy is not automatic — plan the step in" as a standing lesson for four consecutive releases, framed as something to remember.
It is not a discipline problem.
wp-deploy.ymldeclares:That path has fired zero times in six releases. Every deploy in the repo's history is
workflow_dispatch.Cause confirmed in source, not inferred:
release.yml:36publishes the Release withsoftprops/action-gh-release@v3and notoken:input, so it authenticates as the defaultGITHUB_TOKEN— and GitHub does not create workflow runs fromGITHUB_TOKEN-generated events. The trigger cannot fire.Worth fixing rather than remembering because the failure is quiet in the worst way: the tag lands, the Release publishes with its ZIP, CI is green, and every visible signal says shipped while users still have the previous version.
The todo recommends having
release.ymlinvoke the deploy directly over adding a PAT — a PAT defeats a loop-guard that exists for good reasons, which is a real security tradeoff for a convenience win. It also says not to delete the manual step in the same change that adds the automation, since only a real release can prove the fix.Risk
Planning docs only.
🤖 Generated with Claude Code