release: prep v1.5.1 - #146
Merged
Merged
Conversation
Version strings bumped via bin/prep-release.sh (plugin header, MAESTRO_VERSION, Stable tag, package.json + lock). The changelog is derived from the `v1.5.0..main` DIFF, not the phase list — v1.4.0's gate 8 caught an overclaim by doing exactly that, so it is done first here rather than last. The shippable diff is four files: assets/maestro.css, assets/maestro.js, includes/class-config.php, includes/class-replay.php. Six entries, covering both unreleased code commits: f04dd13 (Phase 25) — the reserved toolbar status slot (measured: the status grew 4px -> 24px and displaced the rename field 20px on every save), the a11y M2 locked-checkbox change (aria-disabled instead of native disabled, so the row stays reachable and its reason is finally announced rather than merely written), the M3 focus return on click-away dismissal, and the lightened focus ring. The focus ring is described as a clarity improvement, NOT a compliance fix. The old #2271b1 ring PASSED WCAG 1.4.11 at 3.07:1; it passed by 0.07, and the change is a deliberate robustness margin. Claiming a fix would be the same species of overclaim gate 8 caught. 4359994 (Phase 20 follow-ups) — the Axis-2 drift fix, written user-facing because its effect was: the popover could show roles checked while replay applied nothing, and autosave's full-replace could then store the lie. Plus the entity collision, kept to one internal line. NOT claimed: the child-role-lock predicate parity change. It routes the popover through the already-tested exported predicate instead of a re-inlined copy — real value, zero behavior change, so it does not belong in a user changelog. Upgrade Notice is 287 chars (Plugin Check limit 300). Gate (local, Docker-free lanes): unit 167/167 (223 assertions), JS 83/83, doc-links clean, composer lint clean (11 files), PHPStan 0 errors. Integration and e2e run in CI. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump + changelog for the patch release. Do not merge without reading the changelog copy —
26-01isautonomous: falsefor exactly this reason.What is actually in this release
I diffed
v1.5.0..mainrather than trusting the phase list — v1.4.0's gate 8 caught a changelog overclaim precisely there. Fifteen commits since the tag, but only two touch shippable code:f04dd13Phase 25 toolbar polishassets/maestro.css,assets/maestro.js4359994Phase 20 follow-upsassets/maestro.js,includes/class-config.php,includes/class-replay.phpEverything else is planning docs.
Changelog decisions worth checking
#2271b1ring passed WCAG 1.4.11 at 3.07:1 — by 0.07. The CSS comment says so explicitly. Calling it a fix would be the same species of overclaim gate 8 caught.Gate
Docker-free lanes green locally: unit 167/167 (223 assertions), JS 83/83, doc-links clean,
composer lintclean, PHPStan 0 errors. Integration + e2e run here in CI.Still to do after this merges
v1.5.1onmain, publish the GitHub ReleaseversionfieldOpen question for you
Screenshots. The v1.4.0 checklist has a "directory assets match shipping UI" gate. Both UI changes here are state-dependent — the reserved slot only shows during a save, the focus ring only on focus — so I believe the committed screenshots are still accurate and did not recapture. Worth your call, not mine.
🤖 Generated with Claude Code