Skip to content

Conversation

@dkhalife
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 21, 2025 01:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the GitHub Actions workflow for the Go release by adjusting the directory navigation in the "Build Frontend" job.

  • Removed the initial "cd frontend-code" command before exporting VITE_BACKEND_VERSION
  • Added "cd frontend-code" immediately before running the build command to ensure the correct working directory for the frontend build
Comments suppressed due to low confidence (1)

.github/workflows/go-release.yml:41

  • Removing 'cd frontend-code' before exporting VITE_BACKEND_VERSION changes the working directory, which might affect the git command's output. Confirm that computing the backend version from the repository root is intentional.
export VITE_BACKEND_VERSION=$(git tag --sort=-creatordate | sed -n '1p' | sed 's/^v//')

@dkhalife dkhalife merged commit a042ac0 into main Mar 21, 2025
4 checks passed
@dkhalife dkhalife deleted the dev/dakhalif/backend-version branch March 21, 2025 01:17
dkhalife added a commit that referenced this pull request Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants