adopt UTC time format #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
dkhalife
commented
Mar 1, 2025
dkhalife
commented
- remove completed date param
- remove completed date param
Contributor
There was a problem hiding this comment.
PR Overview
This pull request updates due date handling to adopt RFC3339 (UTC) time format and removes the manual completed date parameter.
- Change NextDueDate (and DueDate) type from int64 to string in API requests.
- Update date parsing logic to use time.Parse with RFC3339 and ensure dates are converted to UTC.
- Remove support for a user-specified completed date in favor of using the current UTC time.
Reviewed Changes
| File | Description |
|---|---|
| internal/apis/task.go | Changed date parameter types and updated parsing logic to enforce UTC time (RFC3339 format); removed completed date parameter |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
internal/apis/task.go:409
- [nitpick] Consider updating the error message to specify that the expected format is RFC3339 (e.g. appending '(RFC3339 format)') for clarity.
"error": "Due date must be in UTC format",
dkhalife
added a commit
that referenced
this pull request
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.