Implement rpc services and ts client #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements gRPC services on the backend (Go) and a corresponding TypeScript gRPC-web client on the frontend. The implementation includes services for tasks, labels, users, tokens, and authentication, with no live connection enabled yet (to be feature-flagged in a future PR).
Key changes:
- Added TypeScript gRPC-web client with authentication middleware and token refresh logic
- Implemented Go gRPC server handlers for Task, Label, User, Token, and Auth services
- Added type conversion functions between gRPC protobuf types and internal models
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| frontend/src/grpc/client.ts | Implements gRPC-web client factory and exports typed API methods for all services with authentication metadata provider |
| apiserver/internal/grpc/user.go | Implements UserGRPCServer with profile retrieval, notification settings, and password change handlers |
| apiserver/internal/grpc/task.go | Implements TaskGRPCServer with full CRUD operations, task completion/skipping, and history retrieval plus model conversion utilities |
| apiserver/internal/grpc/label.go | Implements LabelGRPCServer with CRUD operations for user labels |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No live connection yet, will enable behind a FF in an upcoming PR