Skip to content

Conversation

@dkhalife
Copy link
Owner

@dkhalife dkhalife commented Jan 4, 2025

No description provided.

Copilot AI review requested due to automatic review settings January 4, 2025 16:10
@dkhalife dkhalife enabled auto-merge (squash) January 4, 2025 16:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • .github/workflows/go-release.yml: Evaluated as low risk
  • internal/chore/scheduler.go: Evaluated as low risk
  • internal/circle/handler.go: Evaluated as low risk
  • internal/label/handler.go: Evaluated as low risk
  • internal/chore/api.go: Evaluated as low risk
Comments suppressed due to low confidence (3)

internal/user/handler.go:596

  • [nitpick] The error message 'Error getting users' is too generic. Consider providing a more specific error message.
c.JSON(500, gin.H{ "error": "Error getting users" })

internal/user/handler.go:589

  • Ensure that the new route 'api/v1/users' is covered by tests.
userRoutes := router.Group("api/v1/users")

internal/user/handler.go:603

  • Ensure that the new route 'api/v1/auth' is covered by tests.
authRoutes := router.Group("api/v1/auth")

# Log in to Docker Hub
# I added QEMU Emulation support for non-native architectures and also Buildx to enables multi-architecture. not sure if there is better/faster way to do this
- name: Set up QEMU
uses: docker/setup-qemu-action@v3

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Go Release' step
Uses Step
uses 'docker/setup-qemu-action' with ref 'v3', not a pinned commit hash
uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Go Release' step
Uses Step
uses 'docker/setup-buildx-action' with ref 'v3', not a pinned commit hash
run: |
docker push ${{ secrets.DOCKER_USERNAME }}/donetick:latest
- name: Build and push Docker image
uses: docker/build-push-action@v5

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Go Release' step
Uses Step
uses 'docker/build-push-action' with ref 'v5', not a pinned commit hash
@dkhalife dkhalife merged this pull request into develop Jan 4, 2025
4 checks passed
@dkhalife dkhalife deleted the merge/main/to/develop branch January 4, 2025 16:12
dkhalife added a commit that referenced this pull request Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants