Add request ID to websocket types #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a RequestID field to WebSocket request and response types, ensures it’s echoed back by the server, and updates tests accordingly.
- Added
RequestIDtoWSMessageandWSResponsestructs with JSON tags. - Updated
handleMessageinserver.goto copyRequestIDfrom request to response. - Extended
server_test.goto send and verifyRequestIDin WebSocket tests.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/ws/message.go | Added RequestID field to WSMessage and WSResponse structs |
| internal/ws/server.go | Echoed RequestID in handleMessage response |
| internal/ws/server_test.go | Updated tests to include and assert RequestID |
Comments suppressed due to low confidence (1)
internal/ws/server_test.go:194
- It may be helpful to assert the expected
Statusin this test to ensure the server is returning the correct status code alongside the request ID.
s.Equal("1", resp.RequestID)
| type WSMessage struct { | ||
| Action string `json:"action"` | ||
| Data json.RawMessage `json:"data,omitempty"` | ||
| RequestID string `json:"requestId"` |
There was a problem hiding this comment.
[nitpick] Consider adding omitempty to the JSON tag for RequestID in WSMessage if it can be optional, to avoid sending empty fields when no ID is provided.
Suggested change
| RequestID string `json:"requestId"` | |
| RequestID string `json:"requestId,omitempty"` |
dkhalife
added a commit
that referenced
this pull request
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RequestIDinWSMessageandWSResponseRequestIDback inhandleMessageTesting
go test ./...https://chatgpt.com/codex/tasks/task_e_6872f9621188832ab5871a4ddebebfb7