Refactor logger and cleanup middleware #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the logger setup by making NewLogger private as newLogger, removes the unused request ID constant and timeout middleware, and updates tests accordingly.
- Changed
NewLoggertonewLoggerand adjusted references inDefaultLoggerand tests - Removed unused
XRequestIdKeyconstant andTimeoutMiddlewarefrom middleware package - Updated tests to call
newLoggerinstead ofNewLogger
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/utils/middleware/middleware.go | Dropped unused imports, XRequestIdKey, and timeout middleware |
| internal/services/logging/logging.go | Renamed NewLogger to newLogger and updated callers |
| internal/services/logging/logging_test.go | Updated test to call newLogger instead of NewLogger |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
dkhalife
added a commit
that referenced
this pull request
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NewLoggerprivate asnewLoggerXRequestIdKeyconstant andTimeoutMiddlewareTesting
go test ./...https://chatgpt.com/codex/tasks/task_e_6872ce04ea04832a858954c4f3422a26