Skip to content

Fix JWT creation in websocket server tests #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkhalife merged 3 commits into from
Jul 12, 2025
Merged

Fix JWT creation in websocket server tests #146

dkhalife merged 3 commits into from
Jul 12, 2025

Conversation

@dkhalife
Copy link
Owner

@dkhalife dkhalife commented Jul 12, 2025

Summary

  • use the userID argument when creating JWTs for websocket server tests

Testing

  • go test ./...

https://chatgpt.com/codex/tasks/task_e_6871d62ebbc0832ab63ff7b2d32905bd

Copilot AI review requested due to automatic review settings July 12, 2025 03:37
Copilot AI reviewed Jul 12, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the test helper to correctly use the userID parameter when generating JWTs in websocket server tests.

  • Replaces hardcoded "1" claim with a formatted userID value.
  • Adds fmt import to support formatting.

@codecov
Copy link

codecov bot commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

dkhalife and others added 2 commits July 11, 2025 20:38
@dkhalife
Update internal/ws/server_test.go
682d933 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dkhalife
unused
5a847b0
@dkhalife dkhalife merged commit 8d38ab1 into main Jul 12, 2025
5 checks passed
@dkhalife dkhalife deleted the codex/set-userid-to-auth.identitykey-in-server_test branch July 12, 2025 03:44
dkhalife added a commit that referenced this pull request Oct 5, 2025
@dkhalife
Add support for websocket events and handlers (#146)
7778004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkhalife