Skip to content

Conversation

@dkhalife
Copy link
Owner

Summary

  • use the passed transaction in AssignLabelsToTask so delete and create run in one transaction

Testing

  • go test ./... (fails: download forbidden)

https://chatgpt.com/codex/tasks/task_e_6861c6609338832a998e599d98367653

Copilot AI review requested due to automatic review settings June 29, 2025 23:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR ensures that both deletion and creation of task labels are executed in a single transaction by correctly using the passed transaction handle.

  • Replace r.db with tx to ensure that the transactional context is maintained during the operations.

@dkhalife dkhalife enabled auto-merge (squash) June 29, 2025 23:13
@codecov
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/repos/label/label.go 0.00% 0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@dkhalife dkhalife disabled auto-merge June 29, 2025 23:14
@dkhalife dkhalife merged commit 2301dd5 into main Jun 29, 2025
4 of 5 checks passed
@dkhalife dkhalife deleted the codex/update-assignlabelstotask-to-use-tx branch June 29, 2025 23:14
dkhalife pushed a commit that referenced this pull request Oct 5, 2025
…ctory (#126)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants