Skip to content

Conversation

@dkhalife
Copy link
Owner

@dkhalife dkhalife commented Jun 10, 2025

  • add label ids in the dav etag calculation

Copilot AI review requested due to automatic review settings June 10, 2025 18:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the etag generation for CalDAV tasks by including associated label IDs in the calculation and merging the new logic into an existing cleanup job. It also adds documentation explaining the purpose of incorporating label IDs.

  • Add label IDs to the etag calculation to capture changes in label associations.
  • Integrate the label handling logic within the existing etag generation function.
  • Update inline comments for clarity on why label IDs are included.

dkhalife and others added 2 commits June 10, 2025 11:03
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/repos/caldav/caldav.go 0.00% 15 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dkhalife dkhalife merged commit f3ea581 into main Jun 10, 2025
4 of 5 checks passed
@dkhalife dkhalife deleted the dav-etag branch June 10, 2025 18:09
dkhalife added a commit that referenced this pull request Oct 5, 2025
* convert to use date-fns

* Update src/views/History/HistoryCard.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants