Remove redundant debug config #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
dkhalife
commented
Mar 23, 2025
dkhalife
commented
- export before going into frontend repo
- remove redundant debug config
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the redundant debug configuration from the backend by eliminating the dedicated debug flag and instead relying solely on the log_level setting for configuring debug behavior.
- Removes the debug flag from configuration files and the corresponding code in config.go and README.md.
- Updates logging and mode-setting logic in main.go and newServer to use the log_level value.
- Adjusts the Go release workflow to maintain consistency with the frontend build process.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| main.go | Refactoring logging logic to interpret debug via log_level rather than a dedicated flag |
| .github/workflows/go-release.yml | Minor adjustment to frontend build commands |
| config/config.dev.yaml | Removal of the debug property from development config |
| config/config.yaml | Removal of the debug property from production config |
| config/config.go | Removal of the debug field from the server configuration |
| README.md | Update documentation to reflect removal of debug flag |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.