Fix hash() bug reported by Thiago

dkearn · Nov 3, 2016 · ae81f69 · ae81f69
1 parent 8ec0636
commit ae81f69
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/02_end_to_end_machine_learning_project.ipynb b/02_end_to_end_machine_learning_project.ipynb
@@ -446,7 +446,7 @@
     "import hashlib\n",
     "\n",
     "def test_set_check(identifier, test_ratio, hash):\n",
-    "    return hash(identifier).digest()[-1] < 256 * test_ratio\n",
+    "    return hash(str(identifier).encode(\"ascii\")).digest()[-1] < 256 * test_ratio\n",
     "\n",
     "def split_train_test_by_id(data, test_ratio, id_column, hash=hashlib.md5):\n",
     "    ids = data[id_column]\n",
@@ -3438,7 +3438,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.5.1"
+   "version": "3.5.2"
   },
   "nav_menu": {
    "height": "279px",