-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/typoscript-merge_configs #27
Conversation
klyonrad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
also, please squash your changes into one commit afterwards
|
|
||
| Example: ```customer_extension/Configuration/Typoscript/Config/Stages/config.<StageName>.txt``` | ||
| If this path or ```config.<StageName>.txt``` does not exist, the task will be skipped for this path. | ||
| Example: ```customer_extension/Configuration/Typoscript/Config/Stages/config.#{fetch(:stage)}.txt``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use single backticks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fixed that
| cap <stage> typo3:cms:typoscript:merge_configs[:typoscript_config_paths,:typoscript_config_file] | ||
| {% endhighlight %} | ||
| This task is called by ```merge_config_in_base_path```, so you may not need to call it yourself. | ||
| This task is called by <a href="#mergeconfiginbasepath">merge_config_in_base_path</a>, so you may not need to call it yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove all of the hrefs, we might about hyperlinks to other tasks for the whole page in a separate issue
just the task name with single back ticks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed all Tags
a0b89b7 to
e6379fb
Compare
|
Updated Pull Request according to the requested changes - please review again |
e6379fb to
bf57753
Compare
|
Sorry @CuyGuy can you resolve the merge/rebase conflicts please? I'm having a tough time with it and only you have access rights to your fork... |
Also adds documentation for task merge_config_in_base_path
7d74729 to
3791ebc
Compare
|
resolved the merge conflict and updated the pull request, please check again |
klyonrad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot 😃
This adds documentation for tasks "merge_configs" and "merge_config_in_base_path"