Skip to content
This repository was archived by the owner on Jan 30, 2024. It is now read-only.

Conversation

@CuyGuy
Copy link

@CuyGuy CuyGuy commented Apr 19, 2017

This adds documentation for tasks "merge_configs" and "merge_config_in_base_path"

Copy link
Contributor

@klyonrad klyonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

also, please squash your changes into one commit afterwards


Example: ```customer_extension/Configuration/Typoscript/Config/Stages/config.<StageName>.txt```
If this path or ```config.<StageName>.txt``` does not exist, the task will be skipped for this path.
Example: ```customer_extension/Configuration/Typoscript/Config/Stages/config.#{fetch(:stage)}.txt```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use single backticks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fixed that

cap <stage> typo3:cms:typoscript:merge_configs[:typoscript_config_paths,:typoscript_config_file]
{% endhighlight %}
This task is called by ```merge_config_in_base_path```, so you may not need to call it yourself.
This task is called by <a href="#mergeconfiginbasepath">merge_config_in_base_path</a>, so you may not need to call it yourself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all of the hrefs, we might about hyperlinks to other tasks for the whole page in a separate issue

just the task name with single back ticks :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed all Tags

@CuyGuy CuyGuy force-pushed the feature/typo3_guide branch 2 times, most recently from a0b89b7 to e6379fb Compare April 19, 2017 14:58
@CuyGuy
Copy link
Author

CuyGuy commented Apr 19, 2017

Updated Pull Request according to the requested changes - please review again

@CuyGuy CuyGuy force-pushed the feature/typo3_guide branch from e6379fb to bf57753 Compare April 19, 2017 15:13
@klyonrad
Copy link
Contributor

klyonrad commented Apr 20, 2017

Sorry @CuyGuy can you resolve the merge/rebase conflicts please? I'm having a tough time with it and only you have access rights to your fork...

Also adds documentation for task merge_config_in_base_path
@CuyGuy CuyGuy force-pushed the feature/typo3_guide branch from 7d74729 to 3791ebc Compare April 21, 2017 08:02
@CuyGuy
Copy link
Author

CuyGuy commented Apr 21, 2017

resolved the merge conflict and updated the pull request, please check again

Copy link
Contributor

@klyonrad klyonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot 😃

@klyonrad klyonrad merged commit a21dede into dkdeploy:develop Apr 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants