Skip to content

Commit

Permalink
bazel: Don't perform the checkPhase, since it's redundant with instal…
Browse files Browse the repository at this point in the history
…lCheckPhase.

This change is going to be required when upgrading to Bazel 0.20.0,
because in the checkPhase we're not wrapping the Bazel binary yet to
set some necessary default arguments.
  • Loading branch information
mboes authored and Profpatsch committed Dec 14, 2018
1 parent e38c84d commit 463498e
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions pkgs/development/tools/build-managers/bazel/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -180,16 +180,6 @@ stdenv.mkDerivation rec {
--prepend=scripts/bazel-complete-template.bash
'';

# Build the CPP and Java examples to verify that Bazel works.

doCheck = true;
checkPhase = ''
export TEST_TMPDIR=$(pwd)
./output/bazel test --test_output=errors \
examples/cpp:hello-success_test \
examples/java-native/src/test/java/com/example/myproject:hello
'';

installPhase = ''
mkdir -p $out/bin
Expand Down

0 comments on commit 463498e

Please sign in to comment.