Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group and annotate libraries that target a common encoding #106

Merged
merged 9 commits into from
Mar 10, 2025

Conversation

mumbleskates
Copy link
Collaborator

@mumbleskates mumbleskates commented Mar 10, 2025

here's some logic I thought about to present the benchmarked libraries that target the same encoding (like json, cbor, protobuf etc.) more clearly, grouped together and clearly marked in the readme output. It looks like this

there's room to quibble about how this is presented; i just put like "json:<br>" before the crate in the first column of the table, but there's an argument to be made that maybe we could stick like a full-width table cell heading that just says "json" in it, though i'm not sure if that would really look better, and it doesn't seem like github flavored markdown supports merged cells anyway.

@mumbleskates mumbleskates merged commit 1e4ecf4 into djkoloski:master Mar 10, 2025
1 check passed
@finnbear
Copy link
Contributor

finnbear commented Mar 10, 2025

Nice; however, I think you missed some in the README:

@mumbleskates
Copy link
Collaborator Author

  • borsh, capnp, and flatbuffers have no competitors. we could give them names though :)
  • minicbor is technically cbor, but it's doing something significantly different than the other cbor encodings: it's using the cbor format as a carrier for a protobuf-style numerically surrogate keyed encoding rather than outputting field names and so on; this is part of why it's so much faster, and why i argue that it doesn't count as competing with the other cbor libraries and wouldn't necessarily be something you would choose if you needed to read & write cbor data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants