[BUG] - Play chain offset sticks in Songview

[djdiskmachine]

After playing chain with offset, the offset is not reset when returning to Song view and pressing R + Start in Song View.

Steps to reproduce:
Enter ChainView
Go to non-0 offset in chain and press R + Start to play with offset.
Enter SongView
Press R + Start

Expected outcome:
Should play song with regular 0 offset mode for all chains

Actual outcome:
Song plays with the offset that was set previously in ChainView

Why is there even a R + Start conditional in SongView?

[djdiskmachine]

Seems like there were conditionals where the chain offset wasn't reset

diff --git a/sources/Application/Views/SongView.cpp b/sources/Application/Views/SongView.cpp
index 39c8a59..dd74671 100644
--- a/sources/Application/Views/SongView.cpp
+++ b/sources/Application/Views/SongView.cpp
@@ -479,6 +479,8 @@ void SongView::switchSoloMode() {
};

void SongView::onStart() {

• // Always play with zero offset in chains when in SongView
• viewData_->chainRow_ = 0;
  Player *player = Player::GetInstance();
  unsigned char from = viewData_->songX_;
  unsigned char to = from;
  @@ -513,6 +515,8 @@ void SongView::startImmediate() {
  }

void SongView::onStop() {

• // Always play with zero offset in chains when in SongView

• viewData_->chainRow_ = 0;
  Player *player = Player::GetInstance();
  unsigned char from = viewData_->songX_;
  unsigned char to = from;
  @@ -780,9 +784,6 @@ void SongView::processNormalButtonMask(unsigned int mask) {
  updateCursor(1, 0);

              if (mask & EPBM_START) {
  

•                    // Always play with zero offset in chains when in
  

•                    // songview
  

•                    viewData_->chainRow_ = 0;
                     onStart();
                 }
             }