[BUG] - Using "Save Song As" saves to current as well as new project

[danpicton]

Platform/Build:

• 1.4.3-bacon0 (RG35XXPLUS)
• 1.5.0, 1.6.0-bacon0 (X64)

When working with an existing song, and selecting "Save Song As" , any changes made to the current song will be saved to that song's project too.

Replicated across platforms/builds above.

[djdiskmachine]

Thank you for creating this issue!
Please describe the behavior in the following format:

Steps to reproduce: X
Expected behavior: Y
Actual behavior: Z

For example:

Steps to reproduce:
Song has unsaved changes, go to ProjectView and select Save Song As, entering a new project name

Expected behavior:
All unsaved changes are saved to the project with the new name
Project with new name not loaded, user stays in the current project
Unsaved changes can be discarded if the user chooses to

Actual behavior:
Current project is saved
Project with new name is a clone of the newly saved project
Load project with new name

[danpicton]

Ofc!

Steps to reproduce:

1. Open existing song
2. Make changes to song view
3. Go to project view and select "Save Song As"
4. Regen a title for the new song to be created
5. Select "Ok"

Expected behaviour:

• New song created based off the originally opened song, with the changes applied
• New song becomes the active song
• The originally opened song stays in the state it was at when it was opened (i.e. no changes are saved to it)

Actual behaviour:

• Originally opened song is saved, with changes overwriting its state when opened
• New song created based off the originally opened song, with the changes applied
• New song becomes the active song

[djdiskmachine]

OK cool
Are we expecting the user to intuit that unsaved changes are discarded?

[danpicton]

That would be my expectation, but that may not be universal. I can think of examples that fit this model (e.g. MS Word), and examples where the originally opened project would remain active (e.g. vim).

Could a poll in Discord help?

[djdiskmachine]

Yes a poll is a fine idea feel free to make one so we can finish this requirement change :)

[djdiskmachine]

Would you mind helping me out with a code review?

[danpicton]

I've not got lots of c experience, but happy to take a look tonight or tomorrow!

Will also build from branch to kick the tyres :)

[djdiskmachine]

Great its really helpful to just get another pair of eyes on it.
Self-review is like mastering your own song, it works fine most of the time but you really should let someone with another perspective do it. :)