Skip to content

Added flake8 and isort lint tests #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2022

Conversation

deepakdinesh1123
Copy link
Contributor

closes #31

Copy link
Member

@smithdc1 smithdc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this forward 👍

Just a couple small comments. Let me know what you think.

@smithdc1
Copy link
Member

Thanks for the updates.

While we're here it looks like the isort config is of an old style. Can we update the settings to remove the warning? See https://github.com/smithdc1/djangobench/runs/6090042675?check_suite_focus=true#step:5:7

@smithdc1
Copy link
Member

Hi @deepakdinesh1123

I pulled in the latest changes and the warning has now gone 👍

However, the check is still failing, it looks like not all the imports are sorted correctly? 🤔 https://github.com/smithdc1/djangobench/runs/6200435115?check_suite_focus=true

@deepakdinesh1123
Copy link
Contributor Author

deepakdinesh1123 commented Apr 28, 2022

I ran the action in my forked repo but I did not receive any errors -
https://github.com/deepakdinesh1123/djangobench/actions/runs/2240478544

@smithdc1
Copy link
Member

smithdc1 commented May 3, 2022

OK, I checked this out locally and it all seems to work.

Thanks for the PR. 👍

@smithdc1 smithdc1 merged commit 4c88fa8 into django:master May 3, 2022
@smithdc1 smithdc1 changed the title flake8 and isort action checks added Added flake8 and isort lint tests May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub actions checks for flake8 and isort
2 participants