Added Sha-1 to report output #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @adamchainz hope all is well.
I've been thinking about this and made some progress. What I have in mind is setting up a GitHub Action on a schedule to run the benchmark suite and store the outputs in a
datasette.I'd like to add the commit hash to the output from djangobench and this pull request proposes this change. The commit hash is needed so we can easily identify which commit caused a performance regression.
I've already managed to automate a process that creates a datasette of the commit history of Django and is published at heroku, here is the source repo. I wanted to do this, so we can provide a description of the commit. It also exposes other data that may be of interest. Simon's existing tools made this fairly straight forward.