issue #35244: resolution with a reference to the view function does not work in case of an .app_name.
#17896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 21, 2024 16:46
The view function references were *not* backpropagated, now these are backpropagated by checking if this is a view function, and if so thus added to the parent `.reverse_dict`. The approach is however a bit hacky and thus might be redesigned. Fixing #35244 cref: https://code.djangoproject.com/ticket/35244 cref: https://stackoverflow.com/questions/78035103/in-django-is-it-possible-to-use-reverse-redirect-with-a-view-function-not-stri
The view function references were *not* backpropagated, now these are backpropagated by checking if this is a view function, and if so thus added to the parent `.reverse_dict`. The approach is however a bit hacky and thus might be redesigned. Fixing #35244 cref: https://code.djangoproject.com/ticket/35244 cref: https://stackoverflow.com/questions/78035103/in-django-is-it-possible-to-use-reverse-redirect-with-a-view-function-not-stri
|
Closing per ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The view function references were not backpropagated, now these are backpropagated by checking if this is a view function, and if so thus added to the parent
.reverse_dict. The approach is however a bit hacky and thus might be redesigned.cref: https://code.djangoproject.com/ticket/35244
cref: https://stackoverflow.com/questions/78035103/in-django-is-it-possible-to-use-reverse-redirect-with-a-view-function-not-stri