Skip to content

Conversation

@adamchainz
Copy link
Member

@adamchainz adamchainz commented Jun 1, 2024

  1. Indent Python code with four spaces, rather than three.
  2. Modernize and complete the type hints, specifically replacing Dict and List with dict[k, v] and list (or tuple[Any, ...] in the case of Task.args).
  3. Tidy language around asynchronous tasks, including expanding the “async” shorthand and removing its syntax highlighting.
  4. Replace the term “globally-importable” with “module-level”, which is what I understood was meant.
  5. Use the term “enqueueing” consistently.

@adamchainz
Copy link
Member Author

@RealOrangeOne

Copy link
Member

@RealOrangeOne RealOrangeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have absolutely no idea how the indenting got this messed up, but thanks for cleaning it up!

I also the changed wording is much clearer - thanks again.

@RealOrangeOne
Copy link
Member

As you're already here, it'd be great if you could amend #86 (comment) at the same time! 🙂

co-authored-by: Peter Law <PeterJCLaw@gmail.com>
@adamchainz
Copy link
Member Author

As you're already here, it'd be great if you could amend #86 (comment) at the same time! 🙂

Done, merging!

@adamchainz adamchainz merged commit 5e97684 into main Jun 6, 2024
@adamchainz adamchainz deleted the tidy_dep_14 branch June 6, 2024 07:02
@adamchainz adamchainz mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants