Skip to content

Remove get_valid_export_item_pks #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

19greg96
Copy link
Contributor

@19greg96 19greg96 commented Jun 27, 2024

This is a PR on hold until release of v5

Problem

#1864 deprecates the get_valid_export_item_pks method of ExportMixin

Solution

Removed the deprecated method.

Acceptance Criteria

This should be rebased after #1890 is merged.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling f2b00a8 on 19greg96:remove-get_valid_export_item_pks-1864
into 06557c3 on django-import-export:main.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling d44808f on 19greg96:remove-get_valid_export_item_pks-1864
into 8a65860 on django-import-export:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants