Skip to content

Implement selectable fields for admin export view - #1538 #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 11, 2024
Merged

Implement selectable fields for admin export view - #1538 #1734

merged 20 commits into from
Jan 11, 2024

Conversation

cocorocho
Copy link
Contributor

@cocorocho cocorocho commented Jan 9, 2024 •
edited
Loading

resolves #1538

Problem

What problem have you solved?
Implement new feature selectable export fields for admin view.

Solution

How did you solve the problem?
Create new form SelectableFieldsExportForm which creates boolean fields for each resource.

Acceptance Criteria

Have you written tests? Have you included screenshots of your changes if applicable?
Yes

Did you document your changes?
To some extend,
Official documentation is not quite up to date.

  • Export View
    image

  • Export Result
    image

  • Any field selected validation
    image

@cocorocho cocorocho changed the title Implement selectable fields for admin export view - #1538 Implement selectable fields for admin export view - resolves #1538 Jan 9, 2024
@cocorocho cocorocho changed the title Implement selectable fields for admin export view - resolves #1538 Implement selectable fields for admin export view - #1538 Jan 9, 2024
matthewhegarty
matthewhegarty requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, thanks so much for adding this.

I have gone through it and I only have some minor points.

@matthewhegarty matthewhegarty linked an issue Jan 9, 2024 that may be closed by this pull request
Feature request: Allow selectable fields for export in UI #1538
Closed
@matthewhegarty
Copy link
Contributor

@cocorocho would you be ok with me adding some documentation updates to this PR?

@matthewhegarty
Copy link
Contributor

I added some documentation updates.

matthewhegarty
matthewhegarty reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment re semicolons in JS.

matthewhegarty
matthewhegarty approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your hard work in adding this amazing feature 👍

@matthewhegarty matthewhegarty merged commit 0151e59 into django-import-export:release-4 Jan 11, 2024
@cocorocho
Copy link
Contributor Author

Thank you for all your hard work in adding this amazing feature 👍

Glad to help 🎉

@cocorocho cocorocho deleted the selectable-export-fields branch January 11, 2024 19:09
@matthewhegarty matthewhegarty mentioned this pull request Jan 15, 2024
Closed
Viicos added a commit to Viicos/typeshed that referenced this pull request Jan 19, 2025
@Viicos
Tackle django-import-export/django-import-export#1734
9d3b752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhegarty matthewhegarty matthewhegarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Allow selectable fields for export in UI
2 participants
@cocorocho @matthewhegarty